Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Wouldn't the onRowClick of the TitleColumn[0] (vie the entity) already allow to do what this is meant to allow?

[0] https://github.com/RedHatInsights/insights-inventory-frontend/blob/master/src/components/InventoryTable/TitleColumn.js#L12

Hmm, that would require tweaking TitleColumn as it does not allow redirect with activeTab query param. There is an onRowClick prop in InventoryTable readily available that maps to TitleColumn onRowClick function that has the same usage. Do we want to tweak TitleColumn?

Do we want to tweak TitleColumn?

We always want to enhance what we have instead of introducing something new. We have had several occasions in the past where we simply wanted to change where the link navigates to. It seems to me it is time to enhance the onRowClick of the TitleColum.

It seems to me it is time to enhance the onRowClick of the TitleColum.

I am happy to improve. I am thinking about what would be the best way to go as TitleColumn is used in almost all places where InventoryTable is consumed. It is provided to default columns. Would I need to pass a new onTitleColumnClick function from top-level components to down the TitleColumn component?

@bastilian I investigated the scope of changes needed to improve the TitleColumn. It feels to me that it has large-scale changes and testing are needed. I would not want to be blocked with this while there are more important tasks waiting for edge-parity work. I can create a task for this improvement.

@mkholjuraev What changes would be "large-scale"? It would likely just need the addition of a onRowClick property to the entities provided to the InventoryTable.

I am not able to find a clean way to pass onRowClick to TitleColumn. Can you clarify your idea? By large-scale, I mean passing this onRowClick would require me to make changes in multiple functions and test the change in multiple applications to make sure it does not affect them.

@mkholjuraev Is there no getEntities or fetch function that can add a onRowClick prop to each entity it returns?

/retest

Putting in draft mode for #2087